Open
Conversation
jsumners-nr
requested changes
Mar 10, 2026
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
I haven't reviewed any of the functionality at this time. Just some maintenance type suggestions.
I'd like to see jsdoc blocks on all functions, classes, and methods. This will reduce the need to follow all paths to understand what shapes parameters are meant to be and clarify intentions.
rochdev
changed the title
jsumners-nr
approved these changes
Mar 12, 2026
| `rustup target add wasm32-unknown-unknown --toolchain stable` | ||
| - Install dependencies and build the module\ | ||
| `npm install && npm run build` | ||
| `@apm-js-collab/code-transformer` exposes the library. |
Contributor
There was a problem hiding this comment.
I wonder if we'll need this going forward?
Author
There was a problem hiding this comment.
I wasn't sure what to replace this with, so I only removed the Rust part.
Qard
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[RFC] Rewrite Orchestrion in JavaScript
A few features were also carried over from the original iteration of the rewrite:
astQueryfield to filter AST nodes with an esquery query. Thisis mostly meant to be used when experimenting or if what needs to be queried
is not a function.
Supports tracing iterator (sync/async) returning functions (sync/async)will be added in a future PR